Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Add disable_snapshot_annotations = false to work with containerd v1.4.2 and later #2

Merged
merged 1 commit into from Jan 28, 2021
Merged

Add disable_snapshot_annotations = false to work with containerd v1.4.2 and later #2

merged 1 commit into from Jan 28, 2021

Conversation

clelange
Copy link
Contributor

This follows the discussion in containerd/stargz-snapshotter#251 and updates both the documentation as well as the config.toml for containerd.

jblomer
jblomer approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@jblomer jblomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

Just curious, do you happen to know what these annotation are used for?

@siscia siscia merged commit c859824 into cvmfs:master Jan 28, 2021
@siscia
Copy link
Contributor

siscia commented Jan 28, 2021

Thanks a lot @clelange

@siscia
Copy link
Contributor

siscia commented Jan 28, 2021

@jblomer those annotations are the one that passes the layer information to the snapshotter. We need them to know which layer to mount.

@clelange clelange deleted the disable_snapshot_annotations branch January 28, 2021 09:15
@jblomer
Copy link
Member

jblomer commented Jan 28, 2021

Oh, I see: double negation, disable_xyz = false. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jblomer jblomer jblomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clelange @siscia @jblomer